Bot api 3.4 #675
Merged
Bot api 3.4 #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noplanman
commented
Oct 11, 2017
| @@ -654,6 +664,8 @@ private static function limitTelegramRequests($action, array $data = []) | |||
| 'editMessageReplyMarkup', | |||
| 'setChatTitle', | |||
| 'setChatDescription', | |||
| 'setChatStickerSet', | |||
There was a problem hiding this comment.
@jacklul What exactly are the criteria for having methods in the limiter?
I see that some methods are listed, some not.
There was a problem hiding this comment.
API docs stated that only methods sending something or editing something in the chats are affected by limits.
There was a problem hiding this comment.
Ok, so these Sticker Set methods should be limited then 👍
jacklul
approved these changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements latest additions for Bot API 3.4.
Closes #674