Skip to content

Add missing Payment properties to Message entity #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

noplanman
Copy link
Member

Also add missing type checks, removing some unnecessary ones.

@jacklul Just to be safe, Telegram.php:423 really isn't required, right? It's literally an array of all other types except for message, which is checked in the other if. There can't be any other value there anyway, right?

@noplanman noplanman requested a review from jacklul September 20, 2017 21:33
@jacklul
Copy link
Collaborator

jacklul commented Sep 21, 2017

@jacklul Just to be safe, Telegram.php:423 really isn't required, right? It's literally an array of all other types except for message, which is checked in the other if. There can't be any other value there anyway, right?

Correct, "there shouldn't be any other value" - e.g. Telegram releases new update type.

@noplanman
Copy link
Member Author

noplanman commented Sep 21, 2017

Telegram releases new update type

True. I think it's safe to leave it like this and let any new type follow the default behaviour, right?
Only exception is message.

@noplanman noplanman merged commit 7e73592 into php-telegram-bot:develop Sep 22, 2017
@noplanman noplanman deleted the finalise_payments_implementation branch October 7, 2017 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants