Custom namespace fixes again... #1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacklul
force-pushed
the
custom_namespace_fixes_2
branch
from
432dac4 to
5a84c07
Compare
|
I think it should be ok, as that list is generated taking the admin status into account. (Admin check just before loading the commands objects) So if the user isn't an admin, the command won't be in that list anyway. |
noplanman
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getCommandObject()will now return a valid object when using custom namespace (instead of NULL because$filepathis not provided)Not sure if this is secure as it skips check for admin commands access this way.
Previously: #1115