Skip to content

Scrutinizer fixes #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 6, 2020
Merged

Scrutinizer fixes #1068

merged 5 commits into from
Apr 6, 2020

Conversation

noplanman
Copy link
Member

? !
Type improvement
BC Break no
Fixed issues n/a

Summary

  • Remove unnecessary entityof checks.
  • Remove unused Request::$input variable.
  • Fixed various docblock annotations.
  • Allow setting request client to be of type ClientInterface (instead of the concrete Client object)

@noplanman noplanman changed the base branch from master to develop April 4, 2020 13:44
@noplanman noplanman requested a review from a team April 4, 2020 13:48
@noplanman noplanman mentioned this pull request Apr 4, 2020
Closed
@noplanman noplanman force-pushed the scrutinizer_fixes branch from 03ec789 to 0e42ff7 Compare April 4, 2020 13:54
@noplanman noplanman merged commit 229d884 into php-telegram-bot:develop Apr 6, 2020
@noplanman noplanman deleted the scrutinizer_fixes branch April 6, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@noplanman