Skip to content

change lowercase function to mb_strtolower instead of strtolower #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2020

Conversation

enescakir
Copy link
Contributor

? !
Type bug
BC Break no
Fixed issues #1050

Summary

I am trying to get chat_id in a custom command.

$chatID = $this->getMessage()->getChat()->getId();

But it returns null for chat_id all the time if language is set to Turkish.

I tracked issue and strtolower('getId') returns getId in Turkish instead of getid in Entity class.

mb_strtolower('getId') workings corrects and returns getid.

Copy link
Member

@noplanman noplanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

Please add a short message in the CHANGELOG.md too please, in the Unreleased -> Fixed section too, then I can merge this 👍

@enescakir
Copy link
Contributor Author

PTAL @noplanman 👀

@noplanman noplanman merged commit 94af2fb into php-telegram-bot:develop Feb 12, 2020
@noplanman
Copy link
Member

Thanks @enescakir 🎉

@enescakir enescakir deleted the entity-strtolower branch February 15, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants