Feature/33 update filter #1045
Merged
Feature/33 update filter #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VRciF Sorry for this epically late reply... I like this! Could you please rebase and add a note to the changelog as well? @php-telegram-bot/developers What do you think about this? |
|
@noplanman No worry about the late reply. We're all too busy too often. I've rebased and modified the changelog. Please have a look. |
|
@VRciF Thanks so much for this! I've updated it a bit and added the ability to define a custom reason text to be written to the debug log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to provide a method to filter update messages using a custom callback which solves #527.
It is mentioned in php-telegram-bot/telegram-bot-manager#33 (comment) that this might be implemented in the telegram bot manager, I don't use the bot manager currently and only need the core running on my raspberry pi.
Summary
A new method
setUpdateFilter($callback)is introduced.If the $callback returns false, the executed of processUpdate() ends with a ServerResponse where isOk() returns false.The given test case demonstrates the usage.