Mess with custom command loading

[VoDmAl]

Great library. Thank you!

I faced with one issue. Custom commands loading is not very clear. To create my custom command i should put it in a my custom folder. It must be named xxxCommand.php it is ok.
Of course it must extends Longman\TelegramBot\Commands\Command class. It is ok.
But it also must be in Longman\TelegramBot\Commands\ namespace. It is bad.

$command_namespace = __NAMESPACE__ . '\\Commands\\' . $auth . 'Commands\\' . $this->ucfirstUnicode($command) . 'Command'; if (class_exists($command_namespace)) { return new $command_namespace($this, $this->update); }

You put one bit of information into three different places (folder structure, classes hierarchy and classes names). And they are not synchronized.

But you already have methods to check type of command like that:
public function isSystemCommand() { return ($this instanceof SystemCommand); }
So my proposal is to replace namespace check block code to function "class_parents" or "class_implements" check.

I could prepare this patch.

[noplanman]

Hi @VoDmAl, thanks for your message.

Please do elaborate on your idea and let us know what you would change.
As you say, having that redundancy isn't that great and is unnecessary.

When I implemented the new command system I took what existed and built on top of it, instead of maybe rethinking the whole logic of it.

Thanks again!

[ByZer0]

It will be good to load commands from different namespaces. For example, I need to override GenericmessageCommand from SystemCommands to add some custom logic for generic command handling. It looks simple: just create class with same name but in custom directory/namespace. But it is not working this way because of namespace issue: "Cannot declare class because the name is already in use".

[sfortop]

@VoDmAl what status now?

[MicrowaveDev]

Please see my solution

[akalongman]

Will be fixed in next stable version. Discussion is going here #826