Skip to content

Commit 7c9857e

Browse files
authored
Merge pull request #972 from noplanman/housekeeping_git_meta_and_tests
Housekeeping git meta and tests, custom issue templates
2 parents ba25843 + 5e33818 commit 7c9857e

16 files changed

+234
-93
lines changed

.gitattributes

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
/.* export-ignore
2+
/composer.lock export-ignore
3+
/phpcs.xml.dist export-ignore
4+
/phpunit.xml.dist export-ignore
5+
/tests export-ignore

.github/FUNDING.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
github: noplanman, akalongman, jacklul
21
tidelift: packagist/longman%2Ftelegram-bot
32
patreon: phptelegrambot
43
liberapay: PHP-Telegram-Bot

.github/ISSUE_TEMPLATE.md

Lines changed: 0 additions & 26 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/BC_Break.md

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
---
2+
name: 💥 BC Break
3+
about: Have you encountered an issue during an upgrade? 💣
4+
---
5+
6+
<!--
7+
Before reporting a BC break, please consult the changelog and wiki entry for the particular version to make sure it's not an expected change:
8+
- https://github.com/php-telegram-bot/core/blob/master/CHANGELOG.md
9+
- https://github.com/php-telegram-bot/core/wiki/Breaking-backwards-compatibility
10+
-->
11+
12+
### BC Break Report
13+
14+
<--
15+
❗ NEVER put your Telegram API key or any other private details here. (like passwords, user IDs, etc.)
16+
Substitute them like <API_KEY> or <USER_ID> etc.
17+
-->
18+
19+
#### Required Information
20+
21+
<!-- Fill in the relevant information below to help triage your pull request. -->
22+
<!-- Please enter exact version numbers, not just "latest" etc.! -->
23+
24+
| ? | !
25+
| --- | ---
26+
| Operating system | Name and version
27+
| PHP Telegram Bot version | x.y.z
28+
| PHP version | x.y.z
29+
| MySQL version | x.y.z / none
30+
| Update Method | Webhook / getUpdates
31+
| Self-signed certificate | yes / no
32+
| RAW update (if available) | `{...}`
33+
34+
#### Summary
35+
36+
<!-- Provide a summary describing the problem you are experiencing. -->
37+
38+
#### Previous behaviour
39+
40+
<!-- What was the previous (working) behaviour? -->
41+
42+
#### Current behaviour
43+
44+
<!-- What is the current (broken) behaviour? -->
45+
46+
#### How to reproduce
47+
48+
<!--
49+
Provide steps to reproduce the bug.
50+
If possible, also add any relevant code snippet.
51+
-->
52+
53+
#### Expected behaviour
54+
55+
<!-- What was the expected (correct) behaviour? -->

.github/ISSUE_TEMPLATE/Bug.md

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
---
2+
name: 🐞 Bug Report
3+
about: Something is broken? 🔨
4+
---
5+
6+
### Bug Report
7+
8+
<--
9+
❗ NEVER put your Telegram API key or any other private details here. (like passwords, user IDs, etc.)
10+
Substitute them like <API_KEY> or <USER_ID> etc.
11+
-->
12+
13+
#### Required Information
14+
15+
<!-- Fill in the relevant information below to help triage your pull request. -->
16+
<!-- Please enter exact version numbers, not just "latest" etc.! -->
17+
18+
| ? | !
19+
| --- | ---
20+
| Operating system | Name and version
21+
| PHP Telegram Bot version | x.y.z
22+
| PHP version | x.y.z
23+
| MySQL version | x.y.z / none
24+
| Update Method | Webhook / getUpdates
25+
| Self-signed certificate | yes / no
26+
| RAW update (if available) | `{...}`
27+
28+
#### Summary
29+
30+
<!-- Provide a summary describing the problem you are experiencing. -->
31+
32+
### Current behaviour
33+
34+
<!-- What is the current (buggy) behaviour? -->
35+
36+
#### How to reproduce
37+
38+
<!--
39+
Provide steps to reproduce the bug.
40+
If possible, also add any relevant code snippet.
41+
-->
42+
43+
#### Expected behaviour
44+
45+
<!-- What was the expected (correct) behaviour? -->
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
name: 🎉 Feature Request
3+
about: You have a neat idea that should be implemented? 🎩
4+
---
5+
6+
### Feature Request
7+
8+
#### Summary
9+
10+
<!-- Provide a summary of the feature you would like to see implemented. -->
Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
---
2+
name: ❓ Support Question
3+
about: Have a problem that you can't figure out? 🤔
4+
---
5+
6+
### Support Question
7+
8+
<!--
9+
Before asking a question here, please try asking in the support group first.
10+
https://telegram.me/PHP_Telegram_Bot_Support
11+
12+
Keep in mind that GitHub is primarily an issue tracker.
13+
-->
14+
15+
<--
16+
❗ NEVER put your Telegram API key or any other private details here. (like passwords, user IDs, etc.)
17+
Substitute them like <API_KEY> or <USER_ID> etc.
18+
-->
19+
20+
#### Required Information
21+
22+
<!-- Fill in the relevant information below to help triage your pull request. -->
23+
<!-- Please enter exact version numbers, not just "latest" etc.! -->
24+
25+
| ? | !
26+
| --- | ---
27+
| Operating system | Name and version
28+
| PHP Telegram Bot version | x.y.z
29+
| PHP version | x.y.z
30+
| MySQL version | x.y.z / none
31+
| Update Method | Webhook / getUpdates
32+
| Self-signed certificate | yes / no
33+
| RAW update (if available) | `{...}`
34+
35+
#### Summary
36+
37+
<!-- Describe the issue you are facing here. -->

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,19 @@
1-
<!-- Important: If this pull request is not related to any issue and contains a new feature, please create an issue first for discussion. -->
1+
<!--
2+
Important:
3+
If this pull request is not related to any issue and contains a new feature, please create an issue first for discussion.
4+
https://github.com/php-telegram-bot/core/issues/new?template=Feature_Request.md
25
3-
<!-- Make sure this pull request is pointed towards the "develop" branch and refers to any issue that it's related to! -->
6+
Make sure this pull request is pointed towards the "develop" branch and refers to any issue that it's related to!
7+
-->
48

5-
<!-- Explain in detail what this pull request contains. -->
9+
<!-- Fill in the relevant information below to help triage your pull request. -->
10+
11+
| ? | !
12+
|--- | ---
13+
| Type | bug / feature / improvement
14+
| BC Break | yes / no
15+
| Fixed issues | <!-- use #NUM format to reference an issue -->
16+
17+
#### Summary
18+
19+
<!-- Provide a summary of your change. -->

.gitignore

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,28 +5,20 @@
55
.DS_Store
66
.idea
77
.phpintel
8-
composer.phar
9-
10-
# Local System Files (i.e. cache, logs, etc.) #
11-
/cache
12-
/build/logs
13-
/build/coverage
14-
/tmp
15-
16-
# Test Related Files #
17-
/phpunit.xml
18-
19-
#Exception output
20-
TelegramException.log
218

229
# Composer
23-
vendor/
10+
/composer.phar
11+
/vendor
2412

13+
# Test-Related Files
14+
/clover.xml
15+
/phpcs.xml
16+
/phpunit.xml
2517

26-
# phpDocumentor Logs #
18+
# phpDocumentor Logs
2719
phpdoc-*
2820

29-
# OSX #
21+
# OSX
3022
._*
3123
.Spotlight-V100
3224
.Trashes

.scrutinizer.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,4 @@ checks:
3838

3939
tools:
4040
external_code_coverage:
41-
timeout: 120
41+
timeout: 300

.travis.yml

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,22 @@
1-
dist: trusty
2-
sudo: required
31
language: php
2+
sudo: required
3+
dist: trusty
44

55
addons:
66
mariadb: 10.1
77

88
cache:
99
directories:
10-
- "$HOME/.composer/cache"
10+
- vendor
11+
- $HOME/.composer/cache
1112

1213
php:
13-
- 5.5
14-
- 5.6
15-
- 7.0
16-
- 7.1
17-
- 7.2
1814
- 7.3
15+
- 7.2
16+
- 7.1
17+
- 7.0
18+
- 5.6
19+
- 5.5
1920
- nightly
2021
- hhvm
2122

@@ -44,7 +45,7 @@ before_script:
4445

4546
script:
4647
- composer check-code
47-
- if [ "$TRAVIS_PHP_VERSION" == "7.2" ] ; then composer test-cov; else composer test; fi
48+
- if [ "$TRAVIS_PHP_VERSION" == "7.3" ]; then composer test-cov; else composer test; fi
4849

4950
after_script:
50-
- if [ "$TRAVIS_PHP_VERSION" == "7.2" ]; then composer test-cov-upload; fi
51+
- if [ "$TRAVIS_PHP_VERSION" == "7.3" ]; then composer test-cov-upload; fi

.github/CONTRIBUTING.md renamed to CONTRIBUTING.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,37 @@
1-
Contributing
2-
-------------
1+
# Contributing
32

43
The easiest way to contribute is to work on a checkout of your own fork.
54
When working on the `core` repository, it makes sense to rename your fork to `php-telegram-bot`.
65

7-
Before you contribute code, please make sure it conforms to the PSR-2 coding standard and that the unit tests still pass.
6+
Before you contribute code, please make sure it conforms to the PSR-12 coding standard and that the unit tests still pass.
87
You can run the following commands to check if everything is ready to submit:
98

10-
cd php-telegram-bot
11-
composer install
12-
composer check-code
9+
```bash
10+
cd php-telegram-bot
11+
composer install
12+
composer check-code
13+
```
1314

1415
Which should give you no output, indicating that there are no coding standard errors.
1516
And then (remember to set up your test database!):
1617

17-
composer test
18+
```bash
19+
composer test
20+
```
1821

1922
Which should give you no failures or errors. You can ignore any skipped tests as these are for external tools.
2023

21-
Pushing
22-
-------
24+
## Pushing
2325

2426
Development is based on the git flow branching model (see http://nvie.com/posts/a-successful-git-branching-model/)
2527
If you fix a bug please push in hotfix branch.
2628
If you develop a new feature please create a new branch.
2729

28-
Version
29-
-------
30+
## Version
3031

3132
Version number: 0.#version.#hotfix
3233

33-
Further code convention adopted
34-
-------------------------------
34+
## Further code convention adopted
3535

3636
- Each method and class is documented with a docblock
3737

0 commit comments

Comments
 (0)