Escape spaces in PHP binary path

src/Settings.php

@@ -130,7 +130,7 @@ public static function parseArguments(array $arguments)
 
         // Use the currently invoked php as the default if possible
         if (defined('PHP_BINARY')) {
-            $settings->phpExecutable = PHP_BINARY;
+            $settings->phpExecutable = self::escapeString(PHP_BINARY);
         }
 
         foreach ($arguments as $argument) {
@@ -235,6 +235,24 @@ public static function getPathsFromStdIn()
         $lines = explode("\n", rtrim($content));
         return array_map('rtrim', $lines);
     }
+
+    /**
+     * @param string $path
+     * @param string $os
+     * @return string
+     */
+    public static function escapeString(string $path, string $os = PHP_OS)
+    {
+        $path = trim($path);
+
+        if (stripos(strtoupper($os), 'WIN') === 0) {
+            $path = str_replace('^\\', '\\',  preg_replace('`(?<!^) `', '^ ', escapeshellcmd($path)));
+        } else {
+            $path = preg_replace('`(?<!\\\) `', '\ ', escapeshellcmd($path));
+        }
+
+        return $path;
+    }
 }
 
 class ArrayIterator extends \ArrayIterator

tests/Settings.parseArguments.phpt

@@ -144,6 +144,41 @@ class SettingsParseArgumentsTest extends Tester\TestCase
 
         Assert::equal($expectedSettings->syntaxErrorCallbackFile, $settings->syntaxErrorCallbackFile);
     }
+
+    public function testEscapingPathForUnixSystems()
+    {
+        Settings::escapeString('path with spaces');
+
+        $php_path = "path with/spaces between/php.exe";
+        Assert::equal(Settings::escapeString($php_path, 'Darwin'), "path\\ with/spaces\\ between/php.exe");
+    }
+
+    public function testEscapingPathForWindows()
+    {
+        Settings::escapeString('path with spaces');
+
+        $php_path = "path with\spaces between\php.exe";
+        Assert::equal(Settings::escapeString($php_path, 'Windows'), 'path^ with\\\spaces^ between\\\php.exe');
+    }
+
+    public function testEscapingEmptyPath()
+    {
+        Assert::equal(Settings::escapeString(''), '');
+    }
+
+    public function testEscapingPathWithSpecialChars()
+    {
+        $path = "path/with/special&characters";
+
+        Assert::equal(Settings::escapeString($path), "path/with/special\&characters");
+    }
+
+    public function testEscapingPathWithLeadingTrailingSpaces()
+    {
+        $path = "  path with\spaces  ";
+
+        Assert::equal(Settings::escapeString($path), "path\\ with\\\spaces");
+    }
 }
 
 $testCase = new SettingsParseArgumentsTest;