Skip to content

[WIP] Application credentials #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

smarcet
Copy link
Contributor

@smarcet smarcet commented Aug 5, 2021

this feature branch adds the

application credentials to identity api

depicted here

https://docs.openstack.org/keystone/latest/user/application_credentials.html

smarcet added 2 commits August 5, 2021 11:17
* added application credentials option to identity api v3 ( get token )
* update get metadata method
@smarcet
Copy link
Contributor Author

smarcet commented Aug 5, 2021

guys greetings i work for the OSF i do think this feature will be really useful matter of fact we are using this lib to integration openstackid.org with swift object storage using app credentials

regards

@haphan
Copy link
Collaborator

haphan commented Aug 5, 2021 via email

@haphan haphan changed the title Feature/guzzle 7 x [WIP] Application credentials Aug 7, 2021
@haphan
Copy link
Collaborator

haphan commented Aug 7, 2021

I think it would be very useful for this SDK to support application credentials (added since Openstack 3.10 Queen).

Having said that, we probably want to do it in a systematic way; meaning to cover (1) the Application credential API as well as (2) the login flow.

@smarcet Are you able to work on it?

@smarcet
Copy link
Contributor Author

smarcet commented Aug 11, 2021

@haphan as far i understand
PR covers (2) [login flow]
i do think that (1) could be covered on a second PR
regards

@mzur mzur mentioned this pull request Sep 29, 2021
@drzraf
Copy link

drzraf commented Jan 4, 2022

Some additional tweaks:
drzraf@b5ead02

  1. application credentials (at least mine) can not request a scope, so the payload sent to /tokens must be modified according to the authentication method
  2. Fix an error message regarding the supported authentication methods.

@drzraf
Copy link

drzraf commented Jan 13, 2022

@smarcet

@martijnve
Copy link

We have tested this MR in our application and would very much like this to be in the mainline. Is there anything we can do to assist in this feature getting merged?

@smarcet
Copy link
Contributor Author

smarcet commented Dec 19, 2023

@martijnve hello!
i will try to make some time before EOY to review the comments

@k0ka
Copy link
Member

k0ka commented Dec 19, 2023

Hello,

I haven't checked it yet. I hope I'll have some time this week.
Most probably I won't merge it to the mainline without integration tests. And writing them might be quite tricky.

@k0ka
Copy link
Member

k0ka commented Jan 7, 2024

@k0ka k0ka closed this Jan 7, 2024
@drzraf drzraf mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants