Adding tests for Symfony 4 BETA #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The $callbacks are eventually passed to addDequeuerAwareCall, which expects a string, not a Reference object. In Symfony 3, the Reference was cast to a string, which returned the id, so it worked.
|
Actually, it definitely wasn't tested, as the tests failed :). I've pushed the small fix needed for Symfony 4 with an explanation in the commit. Cheers! |
|
Ping! This bundle is broken on 4.0 - this contains a simple fix. Could we merge and tag? |
|
Ping @stloyd! Sorry to be annoying :). But this should be an easy merge and tag (there have been no commits to master since the last tag). Let's do this! Symfony 4.0 is Thursday |
|
@weaverryan Sorry for late merge, but had quite busy week (in fact few weeks ;)). But now it's merged, thanks! |
|
Thank you! It's ok, I realize that I'm expecting a lot of quick attention from people currently. It's unreasonable. So, thank you :) |
|
@stloyd Whoops - I forgot one favor! We need a 1.14.1 tag please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless I'm mistaken, I don't think the tests are yet testing against Symfony 4. This adds that.
As I mentioned in FriendsOfSymfony/FOSUserBundle#2639, there may be a better way of doing this. I'm happy to hear if there is :).
Cheers!