Prevent an iOS crash from didRegisterForRemoteNotificationsWithDeviceToken #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During application starts didRegisterForRemoteNotificationsWithDeviceToken from AppDelegate is fired. It would cause didRegisterForRemoteNotificationsWithDeviceToken from PushPlugin called but a plugin success result is generated.
EddyVerbruggen
added a commit
to Telerik-Verified-Plugins/PushNotification
that referenced
this pull request
Jun 29, 2014
|
Manually partly merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
didRegisterForRemoteNotificationsWithDeviceToken is being called from AppDelegate but send Plugin success result before plugin being init. As a result callbackId is nil and crash CDVPlugin on iOS.