Misleading Manual Binary Placement Instruction in `mix tailwind.install` Download Error Message

[bigscorpions]

Environment

MacOS m4
Elixir: 1.18.4 (compiled with Erlang/OTP 27)
phoenix: 1.8.rc3
phoenix_tailwind` version: 0.3

Problem

When phoenix_tailwind fails to download the Tailwind CLI binary (e.g., due to network issues), the displayed error message provides ambiguous and potentially misleading instructions for manually placing the binary.

Actual behavior

1. When a download fails (e.g., for mix assets.setup or mix tailwind.install --if-missing), the error message contains the line:

   Manually download the executable from the URL above and place it inside "_build/tailwind-macos-arm64"
   

2. This instruction is misleading because:
   • "Place it inside _build/tailwind-macos-arm64" implies _build/tailwind-macos-arm64 is a directory. However, Tailwind.bin_path() refers to the full file path (e.g., _build/tailwind-macos-arm64).
   • The downloaded binary from GitHub is often named tailwindcss-macos-arm64, but the library expects it to be tailwind-macos-arm64 at bin_path(). This renaming isn't mentioned.
3. Following the literal misleading instruction (or not renaming the file) can lead to the binary not being found or correctly recognized by Tailwind.bin_version(), causing commands to re-attempt download or fail.

Expected behavior

The error message should provide clear and unambiguous instructions for manual binary placement. This includes:

1. Explicitly stating that the target is a full file path, not a directory.
2. Clarifying the expected filename (e.g., tailwind-macos-arm64) if it differs from the download name (e.g., tailwindcss-macos-arm64).

Example of desired clarity:
"Manually download the executable from the URL above and place it at the specific path: \"_build/tailwind-#{configured_target()}\" (Note: The downloaded file may need to be renamed to 'tailwind-#{configured_target()}' if it has a 'tailwindcss-' prefix.)"

[josevalim]

Could you please send a PR? :) Feel free to the changes we want and we can adjust anything on the review. Thank you!

[bigscorpions]

I am not sure what is the proper solution. Change the hint message is easy, but the download file name is "tailwindcss-macos-arm64", and in the code using "tailwind-macos-arm64", without css. I think the name should be consistent.

[josevalim]

The problem is that if we change the name now, it will break stuff people downloaded in the past. So we would need to do it in a major version. I think preserving compatibility is best, we should note though the name may not be the same.

[bigscorpions]

The problem is that if we change the name now, it will break stuff people downloaded in the past. So we would need to do it in a major version. I think preserving compatibility is best, we should note though the name may not be the same.

I think so. It is better to note the name is not the same. Do you still need a PR for that?

[josevalim]

You are welcome to send a PR if you want, otherwise we will do it later. :)