Add assess-with-filesystem #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity, what was the bug? Thanks for packaging this up btw :) |
|
I sent you an email about it. Didn't you get it? The code you sent contained: (defun with-buttercup-filesystem--make-parent (spec path)
"If SPEC is a file name, create its parent directory rooted at PATH."
(save-match-data
(string-match "\\(.*\\)/" spec)
(when (match-string 1 spec)
(make-directory (concat path "/" (match-string 1 spec)) t))))which I think is buggy because it calls (defun assess-with-filesystem--make-parent (spec path)
"If SPEC is a file name, create its parent directory rooted at PATH."
(save-match-data
(when (string-match "\\(.*\\)/" spec)
(make-directory (concat path "/" (match-string 1 spec)) t)))) |
This was referenced Nov 14, 2016
Closed
(assess-with-filesystem SPEC &rest FORMS) Create temporary file hierarchy according to SPEC and run FORMS. SPEC is a list of specifications for file system entities which are to be created.
DamienCassou
force-pushed
the
filesystem
branch
from
b1cb57b to
9d7a2f6
Compare
|
It looks like a really nice addition. Do both of you have copyright papers with FSF? I'm planning on adding assess to core! |
|
@phillord I do. |
|
@phillord I have as well. |
|
On master now! Thank you very much, and apologies for slow processing. Busy time of year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work has been done by @Fuco1. I'm only responsible for a bug fix and for the adaptation to
assesssource code.