GSoC 2023: Aniket Agarwal Week 5 #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krashish8, @cvvergara I did very minimal changes and added start_vid and end_vid to one-to-one overload could you please tell me whether these changes would be acceptable or not? |
|
Yes, the output looks good |
Aniket-debug
changed the title
|
@krashish8 I did some changes in types_check.pg please look into it and let me know if I have missed something. |
krashish8
reviewed
Jun 30, 2023
pgtap/ksp/ksp/types_check.pg
Outdated
Comment on lines
31
to
35
| ('{"","","","directed","heap_paths","seq","path_id","path_seq",start_vid,end_vid,"node","edge","cost","agg_cost"}'::TEXT[]), | ||
| ('{"","","","","directed","heap_paths","seq","path_id","path_seq",start_vid,end_vid,"node","edge","cost","agg_cost"}'::TEXT[]), | ||
| ('{"","","","","directed","heap_paths","seq","path_id","path_seq",start_vid,end_vid,"node","edge","cost","agg_cost"}'::TEXT[]), | ||
| ('{"","","","","directed","heap_paths","seq","path_id","path_seq",start_vid,end_vid,"node","edge","cost","agg_cost"}'::TEXT[]), | ||
| ('{"","","","","directed","heap_paths","seq","path_id","path_seq",start_vid,end_vid,"node","edge","cost","agg_cost"}'::TEXT[]) |
There was a problem hiding this comment.
I think the records are duplicated. No use of duplicating the records when using set_eq - https://pgtap.org/documentation.html#set_eq
Aniket-debug
added a commit
to Aniket-debug/GSoC-pgRouting
that referenced
this pull request
Aug 22, 2023
* did very minimal changes and added start_vid and end_vid in one-to-one * fixed pgtap tests * removed duplicates from set_eq
Aniket-debug
added a commit
to Aniket-debug/GSoC-pgRouting
that referenced
this pull request
Aug 23, 2023
* did very minimal changes and added start_vid and end_vid in one-to-one * fixed pgtap tests * removed duplicates from set_eq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
@pgRouting/admins