Remove redundant rubocop disable directive in test/helper.rb#1095
Merged
petergoldstein merged 2 commits intomainfrom Apr 21, 2026
Merged
Remove redundant rubocop disable directive in test/helper.rb#1095petergoldstein merged 2 commits intomainfrom
petergoldstein merged 2 commits intomainfrom
Conversation
The Style/OneClassPerFile disable comment was never needed since the file doesn't define multiple top-level classes. Rubocop now flags it as Lint/RedundantCopDisableDirective. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Minitest 6 added an explicit guard that raises TypeError if any argument to assert_raises is not a Module. The hash `message: 'No server available'` failed this check. Replace all affected call sites with the existing assert_error helper, which rescues the exception and then asserts its message. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rubocop:disable Style/OneClassPerFile/rubocop:enablepair fromtest/helper.rbLint/RedundantCopDisableDirectiveTest plan
bundle exec rubocoppasses with no offenses🤖 Generated with Claude Code