Skip to content

fix: replace use of any type #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peter-evans merged 1 commit into from
Oct 21, 2022
Merged

fix: replace use of any type #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ function findComment(inputs) {
return undefined;
});
}
function getErrorMessage(error) {
if (error instanceof Error)
return error.message;
return String(error);
}
function run() {
return __awaiter(this, void 0, void 0, function* () {
try {
Expand All @@ -118,7 +123,7 @@ function run() {
}
catch (error) {
core.debug((0, util_1.inspect)(error));
core.setFailed(error.message);
core.setFailed(getErrorMessage(error));
}
});
}
Expand Down
9 changes: 7 additions & 2 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ async function findComment(inputs: Inputs): Promise<Comment | undefined> {
return undefined
}

function getErrorMessage(error: unknown) {
if (error instanceof Error) return error.message
return String(error)
}

async function run(): Promise<void> {
try {
const inputs: Inputs = {
Expand All @@ -89,9 +94,9 @@ async function run(): Promise<void> {
core.setOutput('comment-body', '')
core.setOutput('comment-author', '')
}
} catch (error: any) {
} catch (error) {
core.debug(inspect(error))
core.setFailed(error.message)
core.setFailed(getErrorMessage(error))
}
}

Expand Down