Adding get_input() to types that already have public as_str() 🏷️#890
Merged
tomtau merged 7 commits intopest-parser:masterfrom Jul 16, 2023
Merged
Adding get_input() to types that already have public as_str() 🏷️#890tomtau merged 7 commits intopest-parser:masterfrom
tomtau merged 7 commits intopest-parser:masterfrom
Conversation
Reexporting merge_spans.
tomtau
approved these changes
Jul 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Pest team.
This PR is a followup to my last PR Merging Spans ♻️ #887.
In this last PR, I have introduced a getter for
Spanin order to be able to access the privateinputfield of aSpan. This allows to access the original input string without having to pass its reference everywhere in function arguments. In my personal project, I use this feature to be able to mergeSpans.There is no reason not to add this function to other types that also have this private field and a public
as_str()function. I have added meaningful doc and tests and runcargo fmt.I also renamed my tests to all have different names, making test debugging via commands like
cargo test <get_input_test> -- --nocapturenon-ambiguous.