chore: added docs for semver changes in grammar + remove fast-col-line#787
Merged
tomtau merged 1 commit intopest-parser:masterfrom Feb 8, 2023
Merged
chore: added docs for semver changes in grammar + remove fast-col-line#787tomtau merged 1 commit intopest-parser:masterfrom
tomtau merged 1 commit intopest-parser:masterfrom
Conversation
using line_col from pairs is recommended: pest-parser#785 (comment) as it's faster or similar performance after the line-index patch
Contributor
Author
|
The main project I see that used @VirusTotal @plusvic just a heads up that we plan to remove it, given the default line-index for line_col on Pairs is faster or similar performance: #785 (comment) or do you have any special use case for using line_col on Position? |
|
Thanks for the heads-up!. I'm not using |
plusvic
added a commit
to VirusTotal/yara-x
that referenced
this pull request
Feb 7, 2023
This feature will be removed in future versions: pest-parser/pest#787
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using line_col from pairs is recommended: #785 (comment) as it's faster or similar performance after the line-index patch