Fix incorrect col calculate for pair.line_col method, and add integration test for cover it.#768
Conversation
3d42343 to
7085ec4
Compare
col calculate, and add integration test for cover it.col calculate for pair.line_col method, and add integration test for cover it.
74eea2a to
d0e5d70
Compare
806b346 to
d05db1e
Compare
tomtau
left a comment
There was a problem hiding this comment.
Would it be possible to leverage the original line-col function (to give it an extra argument)?
d05db1e to
05ff0dc
Compare
05ff0dc to
f49cee4
Compare
|
The code itself looks solid. I'm a little confused by why this change is needed. I think I just don't quite understand how the lines and cols are determined. Why do we need to start at 1,1 sometimes and 0,0 other times? |
|
@NoahTheDuke In So it call Here is a test fail result, before I change: https://github.com/pest-parser/pest/actions/runs/3899423161/jobs/6659084167 |
|
Cool, thanks. |
Hi @tomtau, when I use the new
pair.line_colmethod in my project.I found that
colvalue is not correct:https://github.com/pest-parser/pest/actions/runs/3899423161/jobs/6659084167
So I try to fix it, and add a complex integration test for cover it.