PMM-13812 Clickhouse cluster support. #4535
Draft
+284
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiriCtvrtka
commented
Sep 23, 2025
| ) | ||
|
|
||
| func main() { | ||
| data := map[string]map[string]any{ |
There was a problem hiding this comment.
Main is used for generate sql files for our tests.
JiriCtvrtka
commented
Sep 23, 2025
|
|
||
| const ( | ||
| databaseEngineSimple = "MergeTree" | ||
| databaseEngineCluster = "ReplicatedMergeTree('/clickhouse/tables/{shard}/metrics', '{replica}')" |
There was a problem hiding this comment.
No need to replace placeholders ({shard} and {replica}). It is working anyway.
JiriCtvrtka
commented
Sep 23, 2025
| "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| type memMigration struct { |
There was a problem hiding this comment.
It is enough to keep rendered migrations in memory. No need to save them into file.
JiriCtvrtka
commented
Sep 23, 2025
| docker run -d --platform=linux/amd64 --name pmm-clickhouse-test -p19000:9000 -p18123:8123 clickhouse/clickhouse-server:23.8.2.7 | ||
| make test-env | ||
|
|
||
| test-env-up-apple: ## Start docker containers used for testing on Apple chips |
There was a problem hiding this comment.
Not needed anymore. Original image is now compatible with Apple silicon.
|
The PR introduces dynamic (template-generated) SQL migrations, allowing the ENGINE type to be changed based on the setup. I wanted to avoid adding more static files for cluster setups, as this approach is more future-proof. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13812
FB: Percona-Lab/pmm-submodules#4047