PMM-14253 Update flow #4525

matejkubinec · 2025-09-15T13:50:48Z

Link to the Feature Build: SUBMODULES-4038

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

Links to related pull requests (optional).

codecov · 2025-09-18T20:23:04Z

Codecov Report

❌ Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.98%. Comparing base (320403c) to head (00f5a8b).

Files with missing lines	Patch %	Lines
managed/models/user_flags_helpers.go	0.00%	4 Missing ⚠️
managed/models/user_flags_model_reform.go	42.85%	4 Missing ⚠️
managed/services/user/user.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                       Coverage Diff                       @@
##           PMM-13652-native-navigation    #4525      +/-   ##
===============================================================
- Coverage                        44.98%   44.98%   -0.01%     
===============================================================
  Files                              356      356              
  Lines                            44808    44813       +5     
===============================================================
+ Hits                             20157    20158       +1     
- Misses                           22999    23002       +3     
- Partials                          1652     1653       +1

Flag	Coverage Δ
admin	`17.48% <ø> (ø)`
agent	`53.30% <ø> (+0.01%)`	⬆️
vmproxy	`73.45% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

matejkubinec · 2025-09-24T11:08:49Z

@idoqo @ademidoff

Hello, would like some feedback on the BE part of this.

I've added a separate snooze updates api endpoint which handled the logic related to snoozing:

Keeps a timestamp of when was the update last snoozed
Mismatch version - resets snooze counter
Increments snooze counter if current snoozed version & payload one matches

Also I've extended settings with snooze duration (currently 7 days) - time after snooze for which an update modal is not shown to the user (configurable via env variable - maybe just for QAs?)

What's missing:

Validation for the snooze duration
Unit tests/code coverage

EDIT:
Maybe one improvement that I'm currently thinking of, since snooze is user specific would an api route like POST /users/me:snoozeUpdate make more sense rather tha having one under server/updates:snooze?

ademidoff · 2025-09-24T11:13:21Z

api/server/v1/server.proto

      description: "Returns PMM Server update status."
    };
  }
+  // SnoozeUpdate snoozes updates for currently logged in user and returns the count and timestamp


Suggested change

// SnoozeUpdate snoozes updates for currently logged in user and returns the count and timestamp

// SnoozeUpdate snoozes updates for an authenticated user and returns the count and timestamp

ademidoff · 2025-09-24T11:20:44Z

api/server/v1/server.proto

  optional bool enable_backup_management = 12;
  // Enable Access Control
  optional bool enable_access_control = 13;
+  // A number of full days for which an update is snoozed. Should have a suffix in JSON: 2592000s, 43200m, 720h.


Suggested change

// A number of full days for which an update is snoozed. Should have a suffix in JSON: 2592000s, 43200m, 720h.

// A number of full days for which an update is snoozed, i.e. a multiple of 24h: 2592000s, 43200m, 720h.

I wonder if it wouldn't be easier to provide an uint here? That'd be simple to read and test, no?

ademidoff · 2025-09-24T11:22:59Z

api/user/v1/user.proto

  string snoozed_pmm_version = 4;
  reserved 5;
+  google.protobuf.Timestamp snoozed_at = 6;
+  uint32 snoozed_count = 7;


Suggested change

uint32 snoozed_count = 7;

uint32 snooze_count = 7;

ademidoff · 2025-09-24T11:25:00Z

managed/models/database.go

+	},
+	112: {
+		`UPDATE settings
+			SET settings = settings || '{"updates": {"snooze_duration": 604800000000000}}'


Let's provide a comment here, i.e. how many days it is.

ademidoff · 2025-09-24T11:29:26Z

managed/services/server/server.go

 	}, nil
 }

+// Snooze updates for specific pmm version for current user


Suggested change

// Snooze updates for specific pmm version for current user

// SnoozeUpdate snoozes the updates for specific pmm version for current user.

ademidoff · 2025-09-24T13:58:07Z

managed/services/user/user.go

 		return nil, err
 	}

+	var snoozedAt *timestamppb.Timestamp


If you put this block past line 85, there will be no need to define the variable.

ademidoff · 2025-09-24T13:59:29Z

managed/services/user/user.go

-		if req.SnoozedPmmVersion != nil {
+
+		// Keep for backwards compatibility, prefer the new snooze updates:endpoint
+		if req.SnoozedPmmVersion != nil && req.SnoozedPmmVersion != &userInfo.SnoozedPMMVersion {


I think we should check the values here, not the pointers, since pointers will be different.

ademidoff · 2025-09-24T14:00:27Z

managed/services/user/user.go

 		return nil, e
 	}

+	var snoozedAt *timestamppb.Timestamp


Same - let's put this block after line 143.

ademidoff · 2025-09-24T14:00:36Z

managed/utils/envvars/parser.go

 				continue
 			}
 			envSettings.EnableUpdates = &b
+		case "PMM_UPDATES_SNOOZE_DURATION":


Suggested change

case "PMM_UPDATES_SNOOZE_DURATION":

case "PMM_UPDATE_SNOOZE_DURATION":

ademidoff · 2025-09-24T14:00:52Z

managed/utils/envvars/parser.go

 			}
 			envSettings.EnableUpdates = &b
+		case "PMM_UPDATES_SNOOZE_DURATION":
+			if envSettings.UpdatesSnoozeDuration, err = parseStringDuration(v); err != nil {


Suggested change

if envSettings.UpdatesSnoozeDuration, err = parseStringDuration(v); err != nil {

if envSettings.UpdateSnoozeDuration, err = parseStringDuration(v); err != nil {

ademidoff · 2025-09-25T07:20:45Z

api/user/v1/user.proto

  string snoozed_pmm_version = 4;
  reserved 5;
+  google.protobuf.Timestamp snoozed_at = 6;
+  uint32 snoozed_count = 7;


Suggested change

uint32 snoozed_count = 7;

uint32 snooze_count = 7;

percona-robot · 2025-09-25T14:40:51Z

managed/services/user/user.go

 	return resp, nil
 }
+
+// SnoozeUpdate snoozes the updates for specific pmm version for current user


🚫 [golangci] _{reported by reviewdog 🐶}
Comment should end in a period (godot)

matejkubinec added 4 commits September 15, 2025 15:47

PMM-14253 Add update modal

2d54fa1

PMM-14253 Add second modal

6b9bfb3

PMM-14253 Add version info

75a6554

PMM-14254 Add snooze count & snooze timestamp

a60ecae

matejkubinec added 6 commits September 19, 2025 11:31

PMM-14253 Fix unit test

4058ebc

PMM-14253 Fix snooze count

fe7e956

PMM-14253 Add snooze api route

7de4969

PMM-14253 Add settings for snooze duration

1358c5e

PMM-14253

d9a5155

PMM-14253 Update FE with new snooze endpoint

50a529b

matejkubinec requested review from ademidoff and idoqo September 24, 2025 11:04

PMM-14253 Fix FE build

6d60bdb

ademidoff reviewed Sep 24, 2025

View reviewed changes

ademidoff reviewed Sep 25, 2025

View reviewed changes

PMM-14253 Refactor api

00f5a8b

percona-robot reviewed Sep 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

PMM-14253 Update flow #4525

PMM-14253 Update flow #4525

matejkubinec commented Sep 15, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

matejkubinec commented Sep 24, 2025 •

edited

Loading

Uh oh!

ademidoff Sep 24, 2025

Uh oh!

ademidoff Sep 24, 2025

Uh oh!

ademidoff Sep 24, 2025

Uh oh!

ademidoff Sep 24, 2025

Uh oh!

ademidoff Sep 24, 2025

Uh oh!

ademidoff Sep 24, 2025

Uh oh!

ademidoff Sep 24, 2025

Uh oh!

ademidoff Sep 24, 2025

Uh oh!

ademidoff Sep 24, 2025

Uh oh!

ademidoff Sep 24, 2025

Uh oh!

ademidoff Sep 24, 2025

Uh oh!

ademidoff Sep 25, 2025

Uh oh!

percona-robot Sep 25, 2025

Uh oh!

Uh oh!

	// SnoozeUpdate snoozes updates for currently logged in user and returns the count and timestamp
	// SnoozeUpdate snoozes updates for an authenticated user and returns the count and timestamp

	// A number of full days for which an update is snoozed. Should have a suffix in JSON: 2592000s, 43200m, 720h.
	// A number of full days for which an update is snoozed, i.e. a multiple of 24h: 2592000s, 43200m, 720h.

	// Snooze updates for specific pmm version for current user
	// SnoozeUpdate snoozes the updates for specific pmm version for current user.

	case "PMM_UPDATES_SNOOZE_DURATION":
	case "PMM_UPDATE_SNOOZE_DURATION":

	if envSettings.UpdatesSnoozeDuration, err = parseStringDuration(v); err != nil {
	if envSettings.UpdateSnoozeDuration, err = parseStringDuration(v); err != nil {

PMM-14253 Update flow #4525

Are you sure you want to change the base?

PMM-14253 Update flow #4525

Conversation

matejkubinec commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

matejkubinec commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

matejkubinec commented Sep 15, 2025 •

edited

Loading

codecov bot commented Sep 18, 2025 •

edited

Loading

matejkubinec commented Sep 24, 2025 •

edited

Loading