return 429 Too Many Requests instead of stacking up requests #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisok
requested review from
a team,
askomorokhov and
percona-csalguero
and removed request for
a team
percona-csalguero
approved these changes
Mar 16, 2021
|
Thanks @percona-csalguero. Do you think this PR can be merged soon? |
JiriCtvrtka
approved these changes
Mar 24, 2021
|
Thanks @JiriCtvrtka. Anything else needed before merging? |
|
@ColinDKelley Lets wait on @askomorokhov review and then I will merge it. |
askomorokhov
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing https://jira.percona.com/browse/PMM-4557
We've been running this in production without issue.
Note that the
processingflag in the closure is separate for the three levels of precision (high-, medium-, and low-resolution). This means that you can run 1 of each of those, but no more. I think this is just what we want.