Skip to content

Add timestamps functionality #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

draganjovanovich
Copy link

@draganjovanovich draganjovanovich commented Aug 15, 2022

Added timestamp option for STDOUT logs, on each line, option can be
toggled from commands input.

return;
static void write_receive_buf(const unsigned char *buf, int len) {
if (!len) return;
if (timestamps) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation looks broken. Please fix.

Copy link
Author

@draganjovanovich draganjovanovich Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used ClangFormat from VIM, and it automatically messed up this file for some reason (tab size indentation probably), i will manually reformat and commit.

Thanks.

Added timestamp option for STDOUT logs, on each line, option can be
toggled from commands input

Signed-off-by: Dragan Jovanović <[email protected]>
@jonrebm
Copy link
Contributor

jonrebm commented Jun 4, 2025

Hi @draganjovanovich
Thank you for your contribution.
I'd like to discuss the motivation for inclusion of this feature with you and @Onuryldztr, who opened a similar PR (#38)
I'm hesitant about merging new features given the minimalistic approach of microcom and maintainer capacities.
Couldn't this also be acheived by extra tooling such as ts from moreutils?
What are reasons why this should be included into microcom?

@jonrebm jonrebm added the feature Adding new functionality label Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants