You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 18, 2023. It is now read-only.
@dragos199993 one last item before I merge this one, we need to remove all instances of Auto-generation will format a description/title/image using the page content because this is no longer relevant. To make things simple, let's just omit those lines completely.
Ahh, missed those 👍, on image I removed it completely, but on title and description added a ternary inside so the rest of the sentence remains.
I don't this info provides enough value to merit the complexity so let's omit that content entirely. We can solely rely on the "auto generate" button label to communicate the functionality. So for example here would be simply:
{`This should be between ${minLength} and ${maxLength} characters. For help in writing quality meta descriptions, see `}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey! @jacobsfletch this is related to the issue #34
Added the condition as you said directly in JSX without the state.