-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(richtext-lexical, plugin-multi-tenant): text editor exposes documents from other tenants #13229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+167
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
GermanJablo
commented
Aug 1, 2025
packages/richtext-lexical/src/features/link/server/baseFields.ts
Outdated
Show resolved
Hide resolved
JarrodMFlesch
requested changes
Aug 1, 2025
packages/richtext-lexical/src/features/link/server/baseFields.ts
Outdated
Show resolved
Hide resolved
JarrodMFlesch
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Before this PR, an internal link in the Lexical editor could reference a document from a different tenant than the active one.
Reproduction:
pnpm dev plugin-multi-tenant
[email protected]
and passwordtest
http://localhost:3000/admin/collections/food-items
and switch between theBlue Dog
andSteel Cat
tenants to see which food items each tenant has.The new test verifies that this is fixed.
How
baseListFilter
is used, but now it's calledbaseFilter
for obvious reasons: it doesn't just filter the List View. Having two different properties where the same function was supposed to be placed wasn't feasible.baseListFilter
is still supported for backwards compatibility. It's used as a fallback ifbaseFilter
isn't defined, and it's documented as deprecated.baseFilter
is injected intofilterOptions
of the internal link field in the Lexical Editor.