Skip to content

feat(Form): enabled opt-in animations for expandable fieldgroup #11843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

feat(Form): enabled opt-in animations for expandable fieldgroup #11843

merged 1 commit into from
Jun 11, 2025

Conversation

thatblindgeye
Copy link
Contributor

What: Closes #11840

Additional issues:

@thatblindgeye thatblindgeye requested a review from mcoker May 22, 2025 17:51
@patternfly-build
Copy link
Contributor

patternfly-build commented May 22, 2025 •
edited
Loading

Preview: https://patternfly-react-pr-11843.surge.sh

A11y report: https://patternfly-react-pr-11843-a11y.surge.sh

@thatblindgeye thatblindgeye mentioned this pull request May 22, 2025
Open
@thatblindgeye thatblindgeye requested review from a team, rebeccaalpert and wise-king-sullyman and removed request for a team May 27, 2025 12:07
rebeccaalpert
rebeccaalpert reviewed May 28, 2025
View reviewed changes
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing appears slightly off compared with the main site? I'm looking at the spacing above those dividers.

Screenshot 2025-05-28 at 9 49 23 AM

@thatblindgeye thatblindgeye requested a review from nicolethoen June 5, 2025 17:13
@mcoker mcoker requested a review from srambach June 6, 2025 19:13
nicolethoen
nicolethoen approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to my comment on TreeView - I think there are very valid reasons why a use case might incline a dev to want to dynamically create and render children of field groups. It may that they didn't load all the information from the backend on page load, and for performance reasons will only retrieve values for the collapsed field groups when they are expanded open... Something to keep in mind

@thatblindgeye
Copy link
Contributor Author

Spacing appears slightly off compared with the main site? I'm looking at the spacing above those dividers.

@rebeccaalpert looks like the bug is also in Core when I copy+paste the React HTML into a Core example and revert the changes locally (other than bumping the Core versions). @srambach just FYI ^ in Rebecca's screenshot above there's a divider between "Nested field group 2 (non-expandable)" and the text input above it, but there's no spacing between the input and the divider.

srambach
srambach approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks with with a followup in core to fix the spacing issue.

@thatblindgeye thatblindgeye mentioned this pull request Jun 11, 2025
Closed
3 tasks
@thatblindgeye
Copy link
Contributor Author

cc @rebeccaalpert patternfly/patternfly#7571 follow up to the issue you mentioned

mcoker
mcoker approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mcoker mcoker merged commit 8c6618b into patternfly:main Jun 11, 2025
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebeccaalpert rebeccaalpert rebeccaalpert approved these changes

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@srambach srambach srambach approved these changes

@nicolethoen nicolethoen nicolethoen approved these changes

@mcoker mcoker mcoker approved these changes

Assignees
No one assigned
Labels
css review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form - support for field group animation
7 participants
@thatblindgeye @patternfly-build @rebeccaalpert @wise-king-sullyman @srambach @nicolethoen @mcoker