Skip to content

chore(deps): update dependency typescript-eslint to ^8.22.0 #11600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 28, 2025
Merged

chore(deps): update dependency typescript-eslint to ^8.22.0 #11600

merged 4 commits into from
Apr 28, 2025

Conversation

Mash707
Copy link
Contributor

@Mash707 Mash707 commented Mar 4, 2025 •
edited by thatblindgeye
Loading

Towards #11491

@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 4, 2025 •
edited
Loading

Preview: https://patternfly-react-pr-11600.surge.sh

A11y report: https://patternfly-react-pr-11600-a11y.surge.sh

@Mash707
Copy link
Contributor Author

Mash707 commented Mar 4, 2025

Investigating the issues currently.
How should I approach fixing these issues? Should I manually fix each one or we have other options to do it?

@thatblindgeye thatblindgeye mentioned this pull request Mar 4, 2025
Open
16 tasks
@Mash707 Mash707 force-pushed the update-typescript-eslint-dependency branch from 7abdb57 to 408798b Compare March 5, 2025 21:00
@Mash707
Copy link
Contributor Author

Mash707 commented Mar 5, 2025

@thatblindgeye @tlabaj adding @typescript-eslint/no-unused-expressions has resolved a lot of errors.

@Mash707
Copy link
Contributor Author

Mash707 commented Mar 5, 2025

I have updated the config files.
References - https://typescript-eslint.io/blog/announcing-typescript-eslint-v8/#rule-breaking-changes
https://typescript-eslint.io/blog/announcing-typescript-eslint-v8/#replacement-of-ban-types

@Mash707 Mash707 force-pushed the update-typescript-eslint-dependency branch from aba5664 to 8681cf9 Compare March 5, 2025 22:09
@thatblindgeye thatblindgeye requested a review from tlabaj March 6, 2025 14:10
@tlabaj tlabaj requested a review from kmcfaul March 12, 2025 14:30
@thatblindgeye
Copy link
Contributor

This will need a rebase

@Mash707 Mash707 force-pushed the update-typescript-eslint-dependency branch 2 times, most recently from 9b9e4a4 to 603309f Compare March 13, 2025 16:54
@Mash707
Copy link
Contributor Author

Mash707 commented Apr 21, 2025

Working on rebasing since there are conflicts.

@Mash707 Mash707 force-pushed the update-typescript-eslint-dependency branch from 603309f to 0eeb73c Compare April 21, 2025 17:44
@Mash707
Copy link
Contributor Author

Mash707 commented Apr 21, 2025

Rebase done.

@Mash707 Mash707 requested a review from nicolethoen April 21, 2025 18:07
@thatblindgeye thatblindgeye merged commit c0ad0ec into patternfly:main Apr 28, 2025
13 checks passed
@Mash707 Mash707 deleted the update-typescript-eslint-dependency branch April 28, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolethoen nicolethoen nicolethoen approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@tlabaj tlabaj Awaiting requested review from tlabaj

@kmcfaul kmcfaul Awaiting requested review from kmcfaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mash707 @patternfly-build @thatblindgeye @nicolethoen