Skip to content

Page - Enhance Handling of Sidebar Prop #11786

@jenny-s51

Description

@jenny-s51

Describe the enhancement or change
A clear and concise description of the request. What is the expected outcome?

The current implementation of the Page component in PatternFly requires developers to explicitly pass sidebar={null} to indicate that no sidebar should be rendered.

For more context, see the discussion in opendatahub-io/odh-dashboard#4069 (comment)

To improve the design and usability of the Page component, we can modify the logic so that both null and undefined result in the same behavior (such as to not reserve space for a sidebar). This way, consumers can simply omit the sidebar prop when they do not want a sidebar.

I.e.:

className={css(
    styles.page,
    !sidebar && styles.modifiers.noSidebar, // Apply modifier when sidebar is falsy
    className
)}

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Yes, we have prioritized this in JIRA for the RHOAI dashboard, targeting the end of the sprint: 05/19/25.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions