Skip to content

Fix invalid type of credProps extension output #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

geel9
Copy link

@geel9 geel9 commented Aug 1, 2023

This PR resolves #415

  • Adds new type, AuthenticationExtensionsCredentialPropertiesOutputs
  • Changes AuthenticatorExtensionsClientOutputs.CredProps type from bool? to AuthenticationExtensionsCredentialPropertiesOutputs?
  • Adds link to spec entry on credProps extension in XML comment for AuthenticatorExtensionsClientOutputs.CredProps to conform with comment pattern in rest of file

@abergs
Copy link
Collaborator

abergs commented Aug 1, 2023

Hello @geel9 and thanks for the PR. I believe this is already solved in #411?

@geel9
Copy link
Author

geel9 commented Aug 1, 2023

Hello @geel9 and thanks for the PR. I believe this is already solved in #411?

Ha -- so it is. I should've looked more carefully at the existing PRs.

@geel9 geel9 closed this Aug 1, 2023
@abergs
Copy link
Collaborator

abergs commented Aug 1, 2023

I appreciate the effort to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid type of AuthenticationExtensionsClientOutputs.CredProps
2 participants