Skip to content

Add build docker image to CI #7332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 9, 2021
Merged

Add build docker image to CI #7332

merged 7 commits into from
Apr 9, 2021

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Apr 9, 2021

New Pull Request Checklist

Issue Description

Adds building docker image to CI

Related issue: closes #7327

Approach

Adds build docker image as CI step; without publishing the image.

TODOs before merging

none

@codecov
Copy link

codecov bot commented Apr 9, 2021 •
edited
Loading

Codecov Report

Merging #7332 (7159c63) into master (9ea355b) will not change coverage.
The diff coverage is n/a.

❗ Current head 7159c63 differs from pull request most recent head d82ffd0. Consider uploading reports for the commit d82ffd0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7332   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files         181      181           
  Lines       13194    13194           
=======================================
  Hits        12389    12389           
  Misses        805      805

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ea355b...d82ffd0. Read the comment docs.

@mtrezza mtrezza requested a review from dplewis April 9, 2021 12:54
@mtrezza
Copy link
Member Author

mtrezza commented Apr 9, 2021 •
edited
Loading

Check verified: fails with local dependency, passes without local dependency.

The check adds less than a minute to the CI process.

@mtrezza mtrezza requested a review from davimacedo April 9, 2021 13:00
@mtrezza mtrezza mentioned this pull request Apr 9, 2021
Merged
@mtrezza
Copy link
Member Author

mtrezza commented Apr 9, 2021 •
edited
Loading

Check currently fails because package.json has a dependency on local package:

"mock-mail-adapter": "file:./spec/support/MockMailAdapter",

dplewis
dplewis approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@dplewis dplewis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about the .dockerignore file. Nice!

@mtrezza
Copy link
Member Author

mtrezza commented Apr 9, 2021

@dplewis docker build is fixed.

Fix only excludes spec/dependencies in .dockerignore to stay lightweight and not copy the whole spec.

@mtrezza mtrezza merged commit bf732b9 into parse-community:master Apr 9, 2021
@mtrezza mtrezza deleted the add-ci-docker-build branch April 9, 2021 14:40
Arul- pushed a commit to Arul-/parse-server that referenced this pull request Apr 12, 2021
@mtrezza @Arul-
Add build docker image to CI (parse-community#7332)
3919b71 
* add build docker image to CI

* remove node setup

* removed local dependency to test passing docker build

* Update CHANGELOG.md

* Revert "removed local dependency to test passing docker build"

This reverts commit a7801e1.

* removed unnecessary docker build options

* fixed docker build
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@mtrezza mtrezza mentioned this pull request Mar 12, 2022
Merged
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo Awaiting requested review from davimacedo

1 more reviewer

@dplewis dplewis dplewis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI check for docker image building
3 participants
@mtrezza @parseplatformorg @dplewis