Add contribution economics to guide #7191
Conversation
* commit 'ccb045b68c5b4d983a90fa125513fc476e4e2387': fix: upgrade @graphql-tools/links from 6.2.4 to 6.2.5 (parse-community#7007) fix: upgrade pg-promise from 10.7.0 to 10.7.1 (parse-community#7009) fix: upgrade jwks-rsa from 1.10.1 to 1.11.0 (parse-community#7008) fix: upgrade graphql from 15.3.0 to 15.4.0 (parse-community#7011) update stale bot (parse-community#6998) fix(beforeSave/afterSave): Return value instead of Parse.Op for nested fields (parse-community#7005) fix(beforeSave): Skip Sanitizing Database results (parse-community#7003) Fix includeAll for querying a Pointer and Pointer array (parse-community#7002) Init (parse-community#6999)
* commit '7f47b0427ea56214d9b0199f0fcfa4af38794e02': Add page localization (parse-community#7128) Improve contribution guide (parse-community#7075) fix: upgrade pg-promise from 10.9.0 to 10.9.1 (parse-community#7170) Add tests against multiple MongoDB versions (parse-community#7161) fix: upgrade mime from 2.4.7 to 2.5.0 (parse-community#7166) fix: upgrade pg-promise from 10.8.7 to 10.9.0 (parse-community#7168) fix: upgrade apollo-server-express from 2.19.1 to 2.19.2 (parse-community#7165) Upgrade @node-rs/bcrypt to latest version (parse-community#7159) Run Prettier after Definitions (parse-community#7164)
Codecov Report
@@ Coverage Diff @@
## master #7191 +/- ##
==========================================
+ Coverage 93.95% 94.04% +0.09%
==========================================
Files 172 172
Lines 12850 12850
==========================================
+ Hits 12073 12085 +12
+ Misses 777 765 -12
Continue to review full report at Codecov.
|
|
@dblythy Your feedback would be appreciated, I noticed you just did a recent PR on the section that I edited. |
|
Looks good @mtrezza, a much needed improvement IMO. Should we perhaps add a line in the "Please do's" around CHANGELOG? |
How? |
|
Perhaps: Please do's:
|
|
I wouldn't duplicate info unless it's necessary, we already have this as a checkbox in the PR template. Now that you say it, I would even remove the docs bullet point. Lookin closer, I think the Please Do's need some refactoring. It sounds like an optional task, but linting for example is a hard requirement for the PR to be merged. So this belongs more into a step-by-step instruction for creating a PR I think. Changelog entry will also soon become a hard requirement when we have the bot ready. |
|
@dblythy regarding your earlier comment, the revamping of the "Please Do's" into a step-by-step guide could be done in a separate PR so I'm going to merge this. |
* added contribution economics * reformat * removed duplicate phrase * more rewording * more rewording
|
🎉 This change has been released in version 5.0.0-beta.1 |
|
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
Improving contribution guide to make contributing more appealing.
Related issue: closes #7190
Approach
TODOs before merging
(none)