New: allow options to be async on Cloud Validator #7155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7155 +/- ##
=======================================
Coverage 94.00% 94.01%
=======================================
Files 172 172
Lines 12868 12873 +5
=======================================
+ Hits 12097 12102 +5
Misses 771 771
Continue to review full report at Codecov.
|
Moumouls
reviewed
Feb 1, 2021
dplewis
approved these changes
Feb 19, 2021
mtrezza
reviewed
Feb 20, 2021
mtrezza
requested changes
Feb 20, 2021
* Ensure pushStatus is properly running * remove duplicate test
dplewis
approved these changes
Feb 23, 2021
|
🎉 This change has been released in version 5.0.0-beta.1 |
Merged
|
🎉 This change has been released in version 5.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
You can set a function to a Validator's field options, but it can't currently be async.
Related issue: #7140
Approach
Allows options to be async and resolves in Parallel with any other validator options.
TODOs before merging