Remove _noBody from Unity SDK request. #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (req.body && req.body._noBody) { | ||
| // Unity SDK sends a _noBody key which needs to be removed. | ||
| // Unclear at this point if action needs to be taken. | ||
| delete req.body._noBody; |
There was a problem hiding this comment.
Seems legit. should we check in the unity SDK why?
|
I agree with @flovilmart. Cautiously accepting, but I don't fully understand what _noBody was originally there for. I hope you do. |
|
I'm no C# expert but looks like it's garbage and set just before a POST request is sent out. |
gfosco
added a commit
that referenced
this pull request
Feb 17, 2016
Remove _noBody from Unity SDK request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #448.