Skip to content

New query condition to match all strings that starts with some other given strings #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eduardbosch
Copy link
Contributor

Hi to all! 🎉

Read the contribution here please 😀

This Pull Request contains the necessary Parse Server changes to work with this new feature in Android and JS SDKs.

Read the feature here please:
parse-community/Parse-SDK-Android#673

Changed files

The changes are on this commit only eduardbosch@7180dac

I don't know how to make the pull request without the lib folder sorry. If anyone can tell me I'll update it. Maybe ignoring it again and committing? (This sounds weird hehe )

I know this Pull Request cannot be accepted

I've added the lib folders for development purposes. I didn't know any other way to import the project with npm directly from github and with compiled sources. Does anyone know how?

In case this should be accepted, I'll remove this folders. Sorry.

@codecov
Copy link

codecov bot commented May 25, 2017

Codecov Report

Merging #3863 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3863      +/-   ##
==========================================
+ Coverage   90.14%   90.17%   +0.02%     
==========================================
  Files         114      114              
  Lines        7550     7550              
==========================================
+ Hits         6806     6808       +2     
+ Misses        744      742       -2
Impacted Files Coverage Δ
src/RestWrite.js 93.26% <ø> (+0.39%) ⬆️
src/Controllers/UserController.js 92.98% <ø> (+0.74%) ⬆️
src/Adapters/Storage/Mongo/MongoTransform.js 82.83% <ø> (-0.15%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.46% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f11ad5...c9dfbcb. Read the comment docs.

@flovilmart
Copy link
Contributor

Can you open a new PR WITHOUT commiting the lib folder please?

@flovilmart
Copy link
Contributor

And by reverting the commit, not removing it. I'm wondering also because there's no test added, and $regex is already tested part of the existing test suite. Why do you need that PR?

@flovilmart flovilmart closed this May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants