fix: Clicking linked pointer with Cmd key in view table doesn't open page in new browser tab

[mtrezza]

Summary

• handle cmd-click on view pointers like Browser pointers

Testing

• npm test
• npm run lint

---

https://chatgpt.com/codex/tasks/task_e_687592a259d4832d954b01aac0357176

Summary by CodeRabbit

• New Features
  • Added the ability to Cmd+click pointer cells in data views to open the referenced object in a new browser tab.

[parse-github-assistant]

I will reformat the title to use the proper commit message syntax.

[parse-github-assistant]

🚀 Thanks for opening this pull request!

[coderabbitai]

📝 Walkthrough

Walkthrough

A new method was introduced to the Views class to handle Cmd+click interactions on pointer cells. The renderRow method was updated so that Cmd+clicking a pointer cell opens the referenced object in a new browser tab, without affecting existing behaviors for other clicks.

Changes

File	Change Summary
src/dashboard/Data/Views/Views.react.js	Added handlePointerCmdClick method; updated renderRow to support Cmd+click on pointer cells for new tab open

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ViewsComponent
    participant Browser

    User->>ViewsComponent: Cmd+click on pointer cell
    ViewsComponent->>ViewsComponent: handlePointerCmdClick({className, id, field})
    ViewsComponent->>Browser: window.open(generatedURL, "_blank")
    Browser-->>User: Opens referenced object in new tab

Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error code ERR_SSL_WRONG_VERSION_NUMBER
npm error errno ERR_SSL_WRONG_VERSION_NUMBER
npm error request to https://10.0.0.28:4873/npm/-/npm-10.9.2.tgz failed, reason: C08C5F4A407F0000:error:0A00010B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:354:
npm error
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-14T23_36_40_419Z-debug-0.log

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[parse-github-assistant]

The label codex cannot be used here.

[parseplatformorg]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/dashboard/Data/Views/Views.react.js (1)

595-605: Solid implementation with appropriate use of prependMountPath.

The method correctly mirrors handlePointerClick logic while using window.open for new tab behavior. Setting prependMountPath=true in generatePath is the right choice for new tab navigation to ensure the full URL is constructed properly.

Consider extracting the common filter creation logic to reduce duplication:

+  createPointerFilter({ id, field = 'objectId' }) {
+    return JSON.stringify([{ field, constraint: 'eq', compareTo: id }]);
+  }

  handlePointerClick({ className, id, field = 'objectId' }) {
-    const filters = JSON.stringify([{ field, constraint: 'eq', compareTo: id }]);
+    const filters = this.createPointerFilter({ id, field });
    const path = generatePath(
      this.context,
      `browser/${className}?filters=${encodeURIComponent(filters)}`
    );
    this.props.navigate(path);
  }

  handlePointerCmdClick({ className, id, field = 'objectId' }) {
-    const filters = JSON.stringify([{ field, constraint: 'eq', compareTo: id }]);
+    const filters = this.createPointerFilter({ id, field });
    window.open(
      generatePath(
        this.context,
        `browser/${className}?filters=${encodeURIComponent(filters)}`,
        true
      ),
      '_blank'
    );
  }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1c9cb03 and 6b7fe57.

📒 Files selected for processing (1)

• src/dashboard/Data/Views/Views.react.js (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/dashboard/Data/Views/Views.react.js (1)

src/lib/generatePath.js (2)

• filters (8-8)
• generatePath (3-34)

🔇 Additional comments (1)

src/dashboard/Data/Views/Views.react.js (1)

331-342: LGTM! Clean event handling implementation.

The onClick handler correctly checks for both hasPill and e.metaKey to ensure it only triggers for Cmd+click on pointer cells, avoiding interference with existing click behaviors on the Pill component or clickable text spans.

[parseplatformorg]

🎉 This change has been released in version 7.3.0-alpha.14