Callbacks not called due to garbage collection

[rostopira]

I've installed this via CocoaPods, but build fails with following error:

Header 'BoltsSwift-Swift.h' not found

P.S.: I use Xcode 10.2

[rostopira]

Solved using

    pod 'ParseLiveQuery'
    pod 'Bolts-Swift', :git => 'https://github.com/bpisano-luna/Bolts-Swift.git'

That's strange

[rostopira]

I can clearly see correct messages from and to websocket, but callbacks never called, what the heck

[rostopira]

weak var Should be included in the docs.

[noobs2ninjas]

@rostopira I am actually started working on getting this project up to speed from many previous unreleased commits. I experienced the same thing you did and it caused me hours of trial and error and I could only get the delegate sorry "Subscription Handling" protocol to work. Where did you find weak var? Thats doesn't makes much sense when you're dealing with asynchronous tasks that passes a closure expression. Nothing during this process has any business being declared weak.

[rostopira]

@noobs2ninjas See this commit in my fork: rostopira@2473020

And weak is still here: https://github.com/parse-community/ParseLiveQuery-iOS-OSX/blob/master/Sources/ParseLiveQuery/Internal/ClientPrivate.swift#L36

[rostopira]

@noobs2ninjas also, weak could make sense, if it were properly documented and actually cancels subscription, but it's not the case

[noobs2ninjas]

Even with documentation the place where it completely falls apart every time is when accessing the client via singleton as you can simply pass in closures eliminating the need to make a reference to anything.

[rostopira]

@noobs2ninjas so, if you agree with me, just remove weak, what's the problem?

[noobs2ninjas]

I do. Just pointing out that it probably should be removed either way. Would you mind updating this issues title and doing a commit from your branch to resolve this issue? I'm looking to do a release soon and would love to get this in there and give you credit for the fix.

[rostopira]

NP, I will do