Skip to content

feat: add toCLLocation and toCLLocationCoordinate2D to ParseGeoPoint #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2022
Merged

feat: add toCLLocation and toCLLocationCoordinate2D to ParseGeoPoint #366

merged 1 commit into from
May 19, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented May 18, 2022

New Pull Request Checklist

Issue Description

There are no properties for converting a ParseGeoPoint to CLLocation and CLLocationCoordinate2D, only methods.

Related issue: #n/a

Approach

Created computed properties named toCLLocation and toCLLocationCoordinate2D and deprecate toCLLocation() and toCLLocationCoordinate2D(). In addition, improve the documentation for these properties.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #366 (67062fd) into main (5a2c5fd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #366   +/-   ##
=======================================
  Coverage   87.90%   87.91%           
=======================================
  Files         114      114           
  Lines       12207    12213    +6     
=======================================
+ Hits        10731    10737    +6     
  Misses       1476     1476           
Impacted Files Coverage Δ
Sources/ParseSwift/Types/Query.swift 94.37% <ø> (ø)
Sources/ParseSwift/Extensions/Date.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Types/ParseGeoPoint.swift 98.90% <100.00%> (+0.07%) ⬆️
Sources/ParseSwift/Objects/ParseUser.swift 86.12% <0.00%> (-0.09%) ⬇️
Sources/ParseSwift/Coding/ParseEncoder.swift 77.77% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a2c5fd...67062fd. Read the comment docs.

@cbaker6 cbaker6 merged commit 6fc9d2d into parse-community:main May 19, 2022
@cbaker6 cbaker6 deleted the geoLocationUpdates branch May 19, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant