Skip to content

fix: delete all stored Parse data and cache when deleteKeychainIfNeeded is true #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 10, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Nov 9, 2021

New Pull Request Checklist

Issue Description

Make sure cache is deleted during first start of app when deleteKeychainIfNeeded = true

Related issue: #n/a

Approach

Delete the cache on first restart when deleteKeychainIfNeeded = true

TODOs before merging

  • Add tests
  • Bump Linux CI to Swift 5.5.1
  • Add entry to changelog

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 9, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #280 (db439f8) into main (a51a8de) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   82.23%   82.25%   +0.01%     
==========================================
  Files         104      104              
  Lines       10574    10574              
==========================================
+ Hits         8696     8698       +2     
+ Misses       1878     1876       -2     
Impacted Files Coverage Δ
Sources/ParseSwift/Parse.swift 98.72% <100.00%> (ø)
Sources/ParseSwift/Protocols/Queryable.swift 0.00% <0.00%> (-16.67%) ⬇️
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 73.82% <0.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a51a8de...db439f8. Read the comment docs.

@cbaker6 cbaker6 merged commit 25b70d9 into main Nov 10, 2021
@cbaker6 cbaker6 deleted the deleteItemsOnFirstStart branch November 10, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant