Skip to content

fix: default cache policy for ParseFile uses SDK default #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2021
Merged

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Nov 4, 2021

New Pull Request Checklist

Issue Description

ParseFile should use the default cache policy set when initializing the SDK.

Remove NSObject comparison from ParseOperation set as it doesn't work well with non NSObjects.

Related issue: #n/a

Approach

Switched policy to previous default policy and cleaned up documentation.

TODOs before merging

  • Add entry to changelog
  • Improve ParseOperation set method
  • Add more tests to ParseOperationTests
  • Add more tests to ParsePointerTests`
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 4, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #274 (5d41508) into main (fa1e07f) will decrease coverage by 0.01%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   82.25%   82.23%   -0.02%     
==========================================
  Files         103      103              
  Lines       10575    10577       +2     
==========================================
  Hits         8698     8698              
- Misses       1877     1879       +2     
Impacted Files Coverage Δ
...ParseSwift/Objects/ParseInstallation+combine.swift 100.00% <ø> (ø)
...urces/ParseSwift/Objects/ParseObject+combine.swift 100.00% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+combine.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParseConfig+combine.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParseFile.swift 80.13% <ø> (-0.45%) ⬇️
Sources/ParseSwift/Operations/ParseOperation.swift 80.85% <80.00%> (-0.57%) ⬇️
Sources/ParseSwift/Types/Pointer.swift 81.42% <100.00%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa1e07f...5d41508. Read the comment docs.

@cbaker6 cbaker6 merged commit af447a6 into main Nov 4, 2021
@cbaker6 cbaker6 deleted the defaultCache branch November 4, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant