Skip to content

feat: Added error comparing #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 3, 2021
Merged

feat: Added error comparing #250

merged 11 commits into from
Oct 3, 2021

Conversation

vdkdamian
Copy link
Contributor

@vdkdamian vdkdamian commented Oct 3, 2021

New Pull Request Checklist

Issue Description

Related issue: #251

Approach

Add the ability to easily compare Swift Errors with ParseErrors.

TODOs before merging

  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Replaced SwiftLint autocorrect with --fix
  • Add test cases
  • Add change log entry

Add the ability to easily compare Swift Errors with ParseErrors.
@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 3, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Oct 3, 2021

Codecov Report

Merging #250 (b885391) into main (51dfbe1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   83.78%   83.83%   +0.04%     
==========================================
  Files          80       80              
  Lines        7370     7392      +22     
==========================================
+ Hits         6175     6197      +22     
  Misses       1195     1195              
Impacted Files Coverage Δ
Sources/ParseSwift/Types/ParseError.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51dfbe1...b885391. Read the comment docs.

@vdkdamian
Copy link
Contributor Author

@cbaker6 Can you review this? And I don't know how to fix these checks.

@cbaker6
Copy link
Contributor

cbaker6 commented Oct 3, 2021

You need to install SwiftLint per the contributors guide and fix all of the warnings and errors

@cbaker6
Copy link
Contributor

cbaker6 commented Oct 3, 2021

You will also need to add testcases and cover all of you additions in https://github.com/parse-community/Parse-Swift/blob/main/Tests/ParseSwiftTests/ParseErrorTests.swift

@vdkdamian
Copy link
Contributor Author

You need to install SwiftLint per the contributors guide and fix all of the warnings and errors

I installed SwiftLint, but it doesn't do anything, the link also doesn't tell me what to do next.

@vdkdamian vdkdamian changed the title Added error comparing feat: Added error comparing Oct 3, 2021
@cbaker6
Copy link
Contributor

cbaker6 commented Oct 3, 2021

I installed SwiftLint, but it doesn't do anything, the link also doesn't tell me what to do next.

After you install Swiftlint, you just build the app as you normally would. The warnings and errors will show in Xcode automatically.

@cbaker6
Copy link
Contributor

cbaker6 commented Oct 3, 2021

You can pull the SwiftLint changes I just committed. It looks like SwiftLint removed a command

@cbaker6
Copy link
Contributor

cbaker6 commented Oct 3, 2021

You will also need to add a changelog entry

@cbaker6
Copy link
Contributor

cbaker6 commented Oct 3, 2021

I think this is a good start and will be useful to developers. Added some recommendations

@cbaker6 cbaker6 linked an issue Oct 3, 2021 that may be closed by this pull request
3 tasks
@cbaker6
Copy link
Contributor

cbaker6 commented Oct 3, 2021

It looks like you didn't "build" the iOS version before you committed or else it would have fixed the linting or at least given you errors on what it can't fix

@vdkdamian
Copy link
Contributor Author

It looks like you didn't "build" the iOS version before you committed or else it would have fixed the linting or at least given you errors on what it can't fix

I build it for iOS and macOS now

@vdkdamian vdkdamian requested a review from cbaker6 October 3, 2021 18:43
@cbaker6
Copy link
Contributor

cbaker6 commented Oct 3, 2021

You need to "commit" the files SwiftLint makes changes to after you build for "iOS", not macOS. You have incorrect spacing in your files that SwiftLint is fixing automatically, but are not part of your latest commit.

All files need to be linted in order to pass the builds.

@vdkdamian
Copy link
Contributor Author

You need to "commit" the files SwiftLint makes changes to after you build for "iOS", not macOS. You have incorrect spacing in your files that SwiftLint is fixing automatically, but are not part of your latest commit.

All files need to be linted in order to pass the builds.

I don't see any changes after building/running on iOS

@cbaker6
Copy link
Contributor

cbaker6 commented Oct 3, 2021

Try to push from Xcode, there are definitely fixes needed for your branch. Be sure you have SwiftLint installed properly if this doesn't work. I can push the changes, but you are going to have to fix this for your future commits. Below is what I see when looking at your branch. You can also see these issues in the Actions failures:

image

@vdkdamian
Copy link
Contributor Author

@cbaker6 I installed SwiftLint via Homebrew, maybe I need to restart my mac. I'll try this tonight. If you can commit it for me, it would be welcome.

@vdkdamian
Copy link
Contributor Author

@cbaker6 I installed SwiftLint via Homebrew, maybe I need to restart my mac. I'll try this tonight. If you can commit it for me, it would be welcome.

Ok, i see what's wrong.

Schermafbeelding 2021-10-03 om 21 18 25

@vdkdamian
Copy link
Contributor Author

@cbaker6 I see you requested a change, is this change ok already?

@cbaker6
Copy link
Contributor

cbaker6 commented Oct 3, 2021

Anything "unresolved" doesn't looked to be fixed from what I can see

@vdkdamian vdkdamian requested a review from cbaker6 October 3, 2021 20:32
@vdkdamian vdkdamian requested a review from cbaker6 October 3, 2021 21:22
@cbaker6
Copy link
Contributor

cbaker6 commented Oct 3, 2021

@novemTeam thanks for making your first contribution to ParseSwift! This looks good!

@cbaker6 cbaker6 merged commit 97011ac into parse-community:main Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to easily compare errors
2 participants