(Browser / React-Native) Support for File Uri Upload #765
Conversation
Codecov Report
@@ Coverage Diff @@
## master #765 +/- ##
==========================================
+ Coverage 90.33% 90.37% +0.03%
==========================================
Files 54 54
Lines 4886 4905 +19
Branches 1084 1089 +5
==========================================
+ Hits 4414 4433 +19
Misses 472 472
Continue to review full report at Codecov.
|
src/ParseFile.js
Outdated
| @@ -317,6 +317,9 @@ const DefaultController = { | |||
| if (XHR) { | |||
| return this.downloadAjax(uri); | |||
| } | |||
| if (process.env.PARSE_BUILD !== 'node') { | |||
There was a problem hiding this comment.
maybe i don't understand what process.env.PARSE_BUILD is, but the way I'm reading this is:
if we're not in node, complain that we don't have XMLHttpRequest, but XMLHttpRequest is in the browser, not node. set me straight here :).
There was a problem hiding this comment.
For browsers that don't support ajax.
https://www.tutorialspoint.com/ajax/ajax_browser_support.htm
There was a problem hiding this comment.
PARSE_BUILD is set when building the sdk.
https://github.com/parse-community/Parse-SDK-JS/blob/master/build_releases.sh
dplewis
changed the title
* Changelog for patch release 2.3.1 * Update CHANGELOG.md * Changelog for patch release 2.3.1 * add more * Update CHANGELOG.md * Add #765
httpandhttpsmodules don't exist in browser