Skip to content

Allow selective reversion of fields in revert() Parse Object instance method. #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Allow selective reversion of fields in revert() Parse Object instance method. #249

wants to merge 7 commits into from

Conversation

omairvaiyani
Copy link
Contributor

E.g. currentUser.revert(‘name’) or movie.revert([‘totalReviews’, ‘totalViews’]);

Improving on this issue request

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@codecov-io
Copy link

codecov-io commented Apr 3, 2016

Codecov Report

Merging #249 into master will increase coverage by 0.97%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   84.35%   85.33%   +0.97%     
==========================================
  Files          46       46              
  Lines        3663     3736      +73     
  Branches      835      859      +24     
==========================================
+ Hits         3090     3188      +98     
+ Misses        573      548      -25
Impacted Files Coverage Δ
src/ParseObject.js 86.13% <ø> (-0.32%) ⬇️
src/ParseQuery.js 94.57% <0%> (-0.01%) ⬇️
src/ParseError.js 100% <0%> (ø) ⬆️
src/ParseFile.js 82.35% <0%> (+0.98%) ⬆️
src/LiveQueryClient.js 86.95% <0%> (+1.86%) ⬆️
src/ParseLiveQuery.js 80% <0%> (+37.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2956dec...df07a51. Read the comment docs.

@ghost ghost added the CLA Signed label Jul 12, 2016
@ghost
Copy link

ghost commented Jul 12, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@omairvaiyani omairvaiyani reopened this Dec 15, 2016
Copy link
Contributor

@flovilmart flovilmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omairvaiyani can you address the conflicts and also, restore the gitignore file and remove the lib folder please?

@omairvaiyani
Copy link
Contributor Author

@flovilmart I'm closing this PR as it's a bit of a mess - re-opened with a clean PR, and test-cases #565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants