fix: Dot notation on JSON arrays doesn't work on PushStatus offset fields
#2194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2194 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 61 64 +3
Lines 6186 6366 +180
Branches 1499 1507 +8
==========================================
+ Hits 6186 6366 +180 ☔ View full report in Codecov by Sentry. |
mtrezza
approved these changes
Jun 28, 2024
parseplatformorg
pushed a commit
that referenced
this pull request
Jun 28, 2024
# [5.2.0-alpha.4](5.2.0-alpha.3...5.2.0-alpha.4) (2024-06-28) ### Bug Fixes * Dot notation on JSON arrays doesn't work on `PushStatus` offset fields ([#2194](#2194)) ([e0eb6f0](e0eb6f0))
|
🎉 This change has been released in version 5.2.0-alpha.4 |
parseplatformorg
pushed a commit
that referenced
this pull request
Jun 29, 2024
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2024-06-29) ### Bug Fixes * Dot notation on JSON arrays doesn't work on `PushStatus` offset fields ([#2194](#2194)) ([e0eb6f0](e0eb6f0))
|
🎉 This change has been released in version 5.2.0-beta.2 |
parseplatformorg
pushed a commit
that referenced
this pull request
Jun 29, 2024
# [5.2.0](5.1.0...5.2.0) (2024-06-29) ### Bug Fixes * `LiveQueryClient.resubscribe` with Parse Server 7 causes many open connections ([#2184](#2184)) ([71b4d17](71b4d17)) * `Parse.Installation` not working when installation is deleted on server ([#2126](#2126)) ([22360b4](22360b4)) * Dot notation on JSON arrays doesn't work on `PushStatus` offset fields ([#2194](#2194)) ([e0eb6f0](e0eb6f0)) * Duplicate pending operations on nested fields ([#2162](#2162)) ([df6df7c](df6df7c)) ### Features * Support dot notation on array fields ([#2120](#2120)) ([25ec684](25ec684))
|
🎉 This change has been released in version 5.2.0 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fset fields
Pull Request
Issue
With the introduction of dot notation on array fields. #2120 doesn't include a check for
PushStatus.sentPerUTCOffsetandPushStatus.failedPerUTCOffset. These fields are a weird mix of dot notation, JSON arrays with numeric offset and dynamic indexes (not a zero indexed json array like the check).This should allow merging the JS SDK to the server, parse-community/parse-server#9128
Approach
Check for PushStatus dot notation fields
Tasks