Set installation to fcm now. #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The push adapter actually ignores the push type and falls back to the device type. It should be OK to classify these pushes as FCM. https://github.com/parse-community/parse-server-push-adapter/blob/master/src/PushAdapterUtils.js#L20 https://github.com/parse-community/parse-server-push-adapter/blob/master/src/ParsePushAdapter.js#L35 We should move off the parse-server GCM module because the FCM send only needs the GCloud project instead of sender ID.
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
=========================================
Coverage 54.09% 54.09%
Complexity 1682 1682
=========================================
Files 123 123
Lines 9736 9736
Branches 1361 1361
=========================================
Hits 5267 5267
Misses 4040 4040
Partials 429 429Continue to review full report at Codecov.
|
|
Oh, nice! That is good to know! |
Jawnnypoo
approved these changes
May 5, 2018
rogerhu
added a commit
to rogerhu/Parse-SDK-Android
that referenced
this pull request
May 6, 2018
This reverts commit f3d47f6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The push adapter actually ignores the push type and falls back to the device type. It should be OK to classify these pushes as FCM.
i.e. this line falls back to using the android deviceMap:
https://github.com/parse-community/parse-server-push-adapter/blob/master/src/PushAdapterUtils.js#L20
The only accepted types are actually
androidandfcm:https://github.com/parse-community/parse-server-push-adapter/blob/master/src/ParsePushAdapter.js#L35
We should move off the parse-server GCM module because the FCM sending needs a service account and database URL instead of a GCM sender ID.