Skip to content

Easier Push Overrides #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2018
Merged

Easier Push Overrides #811

merged 2 commits into from
May 2, 2018

Conversation

Jawnnypoo
Copy link
Member

Right now, if you wanted to have a custom notification, you would have to subclass ParsePushBroadcastReceiver and override methods. Right now, to create a custom notification, you would override getNotification, which returns a notification. Instead, it would be better if the user could override getNotificationBuilder and the user is able to just override what they want to within the builder, instead of being forced into rebuilding the notification completely.

@codecov
Copy link

codecov bot commented May 2, 2018

Codecov Report

Merging #811 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #811   +/-   ##
=========================================
  Coverage     53.46%   53.46%           
  Complexity     1682     1682           
=========================================
  Files           124      124           
  Lines          9852     9852           
  Branches       1380     1380           
=========================================
  Hits           5267     5267           
  Misses         4156     4156           
  Partials        429      429
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/parse/ParsePushBroadcastReceiver.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b84d8d...45806df. Read the comment docs.

@Jawnnypoo Jawnnypoo requested a review from rogerhu May 2, 2018 06:41
@coveralls
Copy link

coveralls commented May 2, 2018

Coverage Status

Coverage remained the same at 57.826% when pulling 45806df on Jawnnypoo:easier-push-overrides into 2b84d8d on parse-community:master.

@@ -12,7 +12,6 @@ Add dependency to the application level `build.gradle` file.

```groovy
dependencies {
implementation 'com.parse:parse-android:latest.version.here'
implementation 'com.parse:parse-android-gcm:latest.version.here'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogerhu rogerhu merged commit bff5381 into parse-community:master May 2, 2018
@Jawnnypoo Jawnnypoo deleted the easier-push-overrides branch May 4, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants