Add configurable serverURL to Parse.Configuration. #330
Conversation
|
By analyzing the blame information on this pull request, we identified @grantland, @richardjrossiii and @wangmengyan95 to be potential reviewers. |
| @@ -8,6 +8,8 @@ | |||
| */ | |||
| package com.parse; | |||
|
|
|||
| import android.net.Uri; | |||
There was a problem hiding this comment.
let's use java.net.URL instead
|
Updated PR. Take another look 😄 |
|
@richardjrossiii updated the pull request. |
| @@ -63,7 +63,7 @@ | |||
| for (ParseRESTObjectCommand command : commands) { | |||
| JSONObject requestParameters = new JSONObject(); | |||
| requestParameters.put("method", command.method.toString()); | |||
| requestParameters.put("path", String.format("/1/%s", command.httpPath)); | |||
| requestParameters.put("path", String.format("%s/%s", server.getPath(), command.httpPath)); | |||
There was a problem hiding this comment.
Trailing slash issue would still appear in batch encoding, I don't have a great solution for that however, ATM.
There was a problem hiding this comment.
Is there an ability to ammend path componenets to path when building a URI?
There was a problem hiding this comment.
How is this prevented in iOS? Just different internal URL logic?
There was a problem hiding this comment.
@grantland yep, simply via different url logic.
We could solve this by doing new URL(server, command.httpPath).getPath(), though that potentially creates a lot of temporary objects in the interim.
There was a problem hiding this comment.
I don't feel strongly either way
There was a problem hiding this comment.
We are doing this for ParseRESTCommand, though
|
@richardjrossiii updated the pull request. |
1 similar comment
|
@richardjrossiii updated the pull request. |
| public Builder server(String server) { | ||
| this.server = server; | ||
| return this; | ||
| } |
There was a problem hiding this comment.
Mind updating the tests to cover this?
|
@richardjrossiii updated the pull request. |
|
LGTM, squash and feel free to merge! |
Moves `server` from ParseObject to ParseRestCommand, and allows it to be
changed via `Builder.server("myUrl")`.
richardjrossiii
force-pushed
the
richardross.configuration.serverurl
branch
from
fe0507b to
01b0638
Compare
…serverurl Add configurable serverURL to Parse.Configuration.
|
@richardjrossiii updated the pull request. |
Moves
serverfrom ParseObject to ParseRestCommand, and allows it to bechanged via
Builder.server("myUrl").