Skip to content

Fix ParseUser#setState(state) unnecessarily creating authData #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Parse/src/main/java/com/parse/ParseUser.java
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ public Task<Void> then(Task<Void> task) throws Exception {
newStateBuilder.put(KEY_SESSION_TOKEN, getSessionToken());
}
// Avoid clearing authData when updating the current user's State via ParseQuery result
if (getAuthData() != null && newState.get(KEY_AUTH_DATA) == null) {
if (getAuthData().size() > 0 && newState.get(KEY_AUTH_DATA) == null) {
newStateBuilder.put(KEY_AUTH_DATA, getAuthData());
}
newState = newStateBuilder.build();
Expand Down
31 changes: 30 additions & 1 deletion Parse/src/test/java/com/parse/ParseUserTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -1428,7 +1428,36 @@ public void testSetCurrentUserStateWithoutAuthData() throws Exception {
// Make sure we keep the authData
assertEquals(1, user.getAuthData().size());
assertEquals(authData, user.getAuthData().get(authType));
// Make sure old state is deleted
// Make sure old state is replaced
assertFalse(user.has("oldKey"));
// Make sure new state is set
assertEquals("testAgain", user.getObjectId());
assertEquals("valueAgain", user.get("key"));
}

@Test
public void testSetStateDoesNotAddNonExistentAuthData() throws Exception {
// Set user initial state
ParseUser.State userState = new ParseUser.State.Builder()
.objectId("test")
.put("oldKey", "oldValue")
.put("key", "value")
.build();
ParseUser user = ParseObject.from(userState);
user.setIsCurrentUser(true);
// Build new state
ParseUser.State newUserState = new ParseUser.State.Builder()
.objectId("testAgain")
.put("key", "valueAgain")
.build();

user.setState(newUserState);

// Make sure we do not add authData when it did not exist before
assertFalse(user.keySet().contains("authData"));
assertEquals(1, user.keySet().size());
assertEquals(0, user.getAuthData().size());
// Make sure old state is replaced
assertFalse(user.has("oldKey"));
// Make sure new state is set
assertEquals("testAgain", user.getObjectId());
Expand Down