Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@tomaka
Copy link
Contributor

@tomaka tomaka commented Aug 23, 2021

Fix paritytech/polkadot#3688

See my comment in the issue.
This debug assertion can legitimately trigger if an error happens at initialization.

@tomaka tomaka added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 23, 2021
@bkchr
Copy link
Member

bkchr commented Aug 23, 2021

bot merge

@ghost
Copy link

ghost commented Aug 23, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Aug 23, 2021

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@ghost ghost merged commit 60fd8cd into paritytech:master Aug 23, 2021
@tomaka tomaka deleted the fix-dot-3688 branch August 23, 2021 09:24
Wizdave97 pushed a commit to Wizdave97/substrate that referenced this pull request Aug 25, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node crash when port taken

2 participants