Skip to content

Removed PRs from summaries #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bullrich merged 2 commits into from
Apr 5, 2023
Merged

Removed PRs from summaries #14

Bullrich merged 2 commits into from
Apr 5, 2023

Conversation

@Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Apr 5, 2023

From the documentation:

GitHub's REST API v3 considers every pull request an issue, but not every issue is a pull request. For this reason, "Issues" endpoints may return both issues and pull requests in the response. You can identify pull requests by the pull_request key. Be aware that the id of a pull request returned from "Issues" endpoints will be an issue id.

This commit filters objects that have a pull_request object

@Bullrich Bullrich requested review from mordamax and rzadp April 5, 2023 11:17
@Bullrich Bullrich requested a review from a team as a code owner April 5, 2023 11:17
@Bullrich Bullrich merged commit 0dbdc4b into main Apr 5, 2023
@Bullrich Bullrich deleted the bullrich/fix-prs-in-summary branch April 5, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mordamax mordamax Awaiting requested review from mordamax

1 more reviewer

@rzadp rzadp rzadp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bullrich @rzadp